Fix Codex env-key authentication readiness - #5807
Conversation
Treat the active provider's configured env_key as a valid Codex authentication path so discovery and spawn readiness do not falsely require CLI login. Co-authored-by: Salman Mohammed <smohammed@squareup.com> Signed-off-by: Salman Mohammed <smohammed@squareup.com>
46f9146 to
7fbe0b1
Compare
|
also worth knowing: claude has the same split you are fixing here — the probe runs |
Why
Codex supports custom providers authenticated through
[model_providers.<id>] env_key, but Buzz relied only oncodex login status. That false negative showed “Sign-in needed” and sent otherwise valid agents into setup mode.What
env_keyand validate that its effective or process environment value is non-emptyRisk Assessment
Low — the change is limited to Codex providers that explicitly declare an
env_key. Missing, malformed, or empty values retain the existing fail-closed login behavior.Validation
bin/just desktop-checkat7fbe0b1447d3c94b242c03d89ca9a15613a6336ebin/just desktop-tauri-testat7fbe0b1447d3c94b242c03d89ca9a15613a6336eReferences
env_key#4755Generated with Codex