Publish successful ACP replies - #5820
Conversation
|
#5811 is the same change: same file, same if this one survives: #5811 carries unit tests on the accumulate/take cycle (including that a second prompt does not inherit the first prompt's text) and this branch does not. that is the behaviour most likely to regress silently, since the failure mode is republishing stale setup output rather than an error. also relevant: #5819 attacks the same symptom from a third angle (promoting |
Retain streamed assistant text and the triggering batch, then sign and publish a threaded kind-9 reply for successful managed-agent turns. Add coverage for chunk accumulation, threading, mentions, signing, and empty responses. Co-authored-by: johncarle <john@niceagents.ca> Signed-off-by: johncarle <john@niceagents.ca>
d2ba3a5 to
9aca746
Compare
What changed
agent_message_chunktext during each ACP promptWhy
Successful managed-agent turns currently return the agent to the pool without publishing the generated text. Agents receive prompts and complete normally, but their replies never reach the relay or channel UI. Failure notices already have a signed publication path; successful responses did not.
This fixes the missing harness boundary while keeping signing keys inside the managed harness rather than exposing them to sandboxed agent subprocesses.
User impact
Managed ACP agents—including Hermes-backed profiles—will visibly reply in channels and DMs after successful turns. Threading and recipient notification metadata are preserved.
Validation
cargo fmt --all -- --checkcargo clippy -p buzz-acp --all-targets -- -D warningscargo test -p buzz-acp(776 tests)Added regression coverage for chunk accumulation, signed reply construction, existing-thread and top-level threading, author p-tags, and whitespace-only responses.