fix(acp): dispatch mentioned forum events - #5936
Conversation
Co-authored-by: Jross1719 <jeremyross1719@gmail.com> Signed-off-by: Jross1719 <jeremyross1719@gmail.com>
e5dc277 to
88ed710
Compare
|
@block/buzz-oss-team Review requested for this focused ACP dispatch fix. It adds explicitly mentioned forum posts/comments (45001/45003) to the default mention-only paths, keeps votes (45002) excluded, and preserves the Local verification on head |
themiguelamador
left a comment
There was a problem hiding this comment.
The forum-kind addition is sound, but the consolidated defaults expose a related message-coverage regression: both normal and setup mention lists omit KIND_STREAM_MESSAGE_V2 (40002). Buzz treats kinds 9 and 40002 as canonical channel messages throughout its message, feed, and mention paths. As written, an ACP agent still never receives a direct mention carried by a v2 stream event, and an unconfigured agent cannot publish its setup nudge for one.
The README's replacement --kinds and TOML examples also omit 40002. Because --kinds replaces the default wholesale, following the documented “all forum activity” setup preserves that same coverage hole.
I fixed the normal/setup defaults, regression assertions, and all documented override lists in 25d100ae1 (review/pr-5936-fix).
Verification completed on the fix commit:
cargo test -p buzz-acp --lib— 777 passedcargo test -p buzz-acp --test '*'— 9 passedcargo test --doc -p buzz-acp— passedcargo clippy -p buzz-acp --all-targets -- -D warningscargo fmt --all -- --checkgit diff --check
Please incorporate the fix commit (or an equivalent change) before merge.
Summary
45001) and forum comments (45003) in the ACP harness's default mention subscriptions45002)Root cause
The ACP harness subscribed to stream messages, workflow requests, and reminders by default, but omitted forum post and comment kinds. The relay's existing
p-tag filter is kind-agnostic, so explicitly mentioned agents were never reached because those forum event kinds were not subscribed.Impact
Agents now wake for forum posts and comments that explicitly mention them. Unmentioned forum traffic and forum votes remain excluded unless an operator opts into broader kinds and disables mention filtering.
Validation
cargo test -p buzz-acp --lib— 777 passedcargo test -p buzz-acp --test '*'— 9 passedcargo test -p buzz-sdk --lib— 257 passedcargo test --doc -p buzz-acp— passedcargo fmt --check -p buzz-acp— passedcargo clippy --workspace --all-targets -- -D warnings— passedgit diff --check— passed