feat: add native desktop review harness - #5958
Open
jedwards27 wants to merge 4 commits into
Open
Conversation
Signed-off-by: Carl <5f365698229751c0461f57bb03a4e93134e6e936bd7039ebe7b737282a43c754@buzz.block.builderlab.xyz>
This was referenced Aug 15, 2026
Fail closed on non-standard fixture ports, use fixed loopback database coordinates, scrub repository-controlled subprocess environments, and remove generated review keys when fixture seeding fails. Co-authored-by: Carl <5f365698229751c0461f57bb03a4e93134e6e936bd7039ebe7b737282a43c754@buzz.block.builderlab.xyz> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
Default harness commands to a credential-free environment and isolate cleanup HOME without reconstructing the host environment. Co-authored-by: Carl <5f365698229751c0461f57bb03a4e93134e6e936bd7039ebe7b737282a43c754@buzz.block.builderlab.xyz> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
Signed-off-by: Carl <5f365698229751c0461f57bb03a4e93134e6e936bd7039ebe7b737282a43c754@buzz.block.builderlab.xyz>
themiguelamador
suggested changes
Aug 16, 2026
themiguelamador
left a comment
There was a problem hiding this comment.
I found several blocking correctness/security issues in the native-review harness:
- The semantic probe accepted unauthenticated cross-origin writes on a wildcard-CORS loopback endpoint and had no request-size cap. A local webpage/process could overwrite evidence or force oversized writes.
- The Swift recorder advanced its frame clock only when AVAssetWriter was ready. Backpressure left the target instant in the past and turned the capture task into a busy-spin.
- The launcher depended on PyYAML without declaring or pinning it, so a clean Hermit checkout could not reliably run the advertised command.
- Journey validation accepted unknown action fields, unsupported keys, booleans as integer durations/timeouts, invalid sustained durations, and duplicate/invalid metric names. The sample
measurefield was silently ignored and absent from the receipt contract. - Relay/bootstrap validation accepted malformed local authorities or invalid pubkeys.
- All four commits include agent authorship or
Co-authored-by: Carlattribution, contrary to this repository’s AGENTS.md attribution rule. This requires replacing the commit history, not an additive fix.
I prepared an attribution-clean, signed replacement at Complear/buzz branch review/pr-5958-fix, commit e278be7ddd9b388d0569c65b26a0fa55916f91bd. It is based on the PR’s true merge base (51beba603) and includes the full PR plus fixes: authenticated/capped probe writes and frontend URL validation, strict journey/relay/pubkey validation, durable measurement receipts and schemas, a backpressure-safe capture clock, and a uv/PyYAML lock.
Verification on that exact tree:
- native-review Python contracts: 23 passed
- semantic probe TypeScript test: passed
- Swift driver release build: passed
- Desktop
pnpm check: passed (only pre-existing warnings/info outside this PR) - Desktop
pnpm typecheck: passed - complete Desktop
pnpm test: passed - JSON/schema syntax, launcher shell syntax, uv lock check, and
git diff --check: passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this is separate from Playwright
This exercises native launch/packaging, WKWebView behavior, macOS input delivery, window capture, timing-sensitive hover behavior, and cleanup boundaries that browser E2E does not establish.
Validation
At clean HEAD
8b3450af0ef952f5a0b5b8e593f29deb523e5d87:git diff --checkpassedRepresentative local receipts:
test-results/native-review/8b3450af0ef9/tooltip_fresh_dwell/tooltip_fresh_dwell-20260815T074527-b4904c/receipt.jsontest-results/native-review/8b3450af0ef9/broken_tooltip/broken_tooltip-20260815T074613-529821/receipt.jsonScope
This is the macOS Desktop MVP. Follow-up stacks will add broader journeys, base/head performance comparison and budgets, iOS Simulator driving/recording, and teammate-grade setup documentation.