fix(dev): stage built desktop sidecars - #5994
Open
ugiya wants to merge 1 commit into
Open
Conversation
Signed-off-by: ugiya <17926591+ugiya@users.noreply.github.com>
themiguelamador
suggested changes
Aug 16, 2026
themiguelamador
left a comment
There was a problem hiding this comment.
The new staging step fixes the native stale-stub path, but two correctness issues remain:
- Source validation and destination replacement are interleaved. If a later sidecar is missing or empty, earlier destinations have already been replaced, leaving the mixed fresh/stale set this preflight is meant to prevent. Validate the full
SIDECARSarray in one loop, then copy in a second loop. - On Windows,
cargo metadataemits a nativeC:\...target directory. This recipe runs under Git Bash and passes that string to Unixcp, so the.exehandling alone is insufficient. Normalize backslashes to forward slashes before constructing source paths.
I applied both fixes locally in signed commit d5ed45112. Verification passed: all six native sidecars staged byte-for-byte from Cargo's resolved target directory, and a simulated missing final sidecar failed without changing the first destination. The Justfile parses and git diff --check passes. A direct push was attempted because maintainer_can_modify is true, but GitHub returned 403 for the authenticated account.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
externalBinpaths before launching Desktop.exehandling and the existing non-Windows Kubernetes sidecar ruleProblem
The Desktop recipes create target-named sidecar stubs so Tauri can validate
externalBin, then build the real binaries in Cargo's root target directory. They did not copy those builds over the stubs before launch.As a result,
just devandjust desktop-standalonecould launch stale sidecars left by an earlier build, or first-run placeholder files, even though Cargo had just produced fresh binaries.Fix
Add
_stage-debug-sidecarsand call it immediately after the sidecar build in both native Desktop launch recipes. The recipe copies only the explicitly declared sidecars and marks them executable on non-Windows hosts. It does not broaden the child processPATH.Verification
Exact pushed head:
650eb931ajust _stage-debug-sidecars: passedbuzz,buzz-acp,buzz-agent,buzz-dev-mcp,git-credential-nostr, andbuzz-backend-kubernetesgit diff --check origin/main...HEAD: passedWindows behavior is covered structurally by the existing target detection and
.exenaming path; it was not executed on this macOS host.