test(desktop): stabilize community validation route check - #6096
Open
kiranmagic7 wants to merge 1 commit into
Open
test(desktop): stabilize community validation route check#6096kiranmagic7 wants to merge 1 commit into
kiranmagic7 wants to merge 1 commit into
Conversation
Signed-off-by: kiranmagic7 <262980978+kiranmagic7@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The community-switch test asserted that the remembered channel was absent from the URL immediately after clicking community B. The switch intentionally writes that channel route before recording B as active, so the negative assertion races the async switch: it can pass against the transient Home route or time out after the switch completes.
Wait for community B's active-community marker, then assert the remembered route. The later assertions still verify that failed live validation preserves the remembered destination and a successful authoritative read repairs it to Home.
Related issue
Addresses the separate
:716failure signature in #6007. #4652 covers only the keyboard-reorder failure from the same issue. No existing pull request covers this route-validation failure.Testing
PLAYWRIGHT_JSON_OUTPUT_NAME=playwright-results.json CI=1 pnpm --dir desktop exec playwright test tests/e2e/community-rail.spec.ts --project=smoke --grep 'does not repair a remembered channel until live validation succeeds' --repeat-each=60 --workers=1 --retries=0 --max-failures=0 --reporter=jsonpnpm --dir desktop exec biome check tests/e2e/community-rail.spec.tspnpm --dir desktop typecheckCHECK_FILE_SIZES_BASE=upstream/main just ci