Accept mention tags in buzz-acp mention filter - #8014
Open
hunchulchoi wants to merge 1 commit into
Open
hunchulchoi wants to merge 1 commit into
hunchulchoi wants to merge 1 commit into
Conversation
Buzz clients emit `["mention", pubkey]` tags for agent-address mentions in channel messages, while `["p", pubkey]` remains the notification mechanism. buzz-acp's require_mention filter only looked for `p` tags, so a mention delivered only via a `mention` tag was silently ignored — the agent never saw the prompt. Match both tag kinds when require_mention is set. Signed-off-by: choi <choi@dgst.me>
🔐 Codex Security Review
|
hunchulchoi
marked this pull request as ready for review
October 1, 2026 03:58
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Buzz clients emit
["mention", pubkey]tags for agent-address mentions in channel messages (seedesktop/src/features/messages/lib/agentAddressMention.mjs), while["p", pubkey]remains the notification mechanism.buzz-acp'srequire_mentionsubscription filter only looked forptags, so a mention delivered solely via amentiontag was silently ignored — the agent never saw the prompt and never responded.Change
In
match_event, treat["mention", <agent_pubkey>, ...]the same as["p", <agent_pubkey>]whenrequire_mentionis set. Any extra tag elements (e.g. theagent-addressmarker) are ignored.Testing
filter::tests::test_match_event_mention_tagcovering an event tagged["mention", agent_pubkey]— fails before, passes after.cargo test -p buzz-acp --lib— 21 tests pass.buzz-acpharness; a channel message carrying only["mention", pubkey](noptag) previously produced no agent response.buzz-review-completed