Add warning option for Query Registry clients #628
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bsorbo
force-pushed
the
bsorbo/query-registry-warning-mode
branch
2 times, most recently
from
d58ed8a to
e88ba46
Compare
This adds a new configuration option 'warn_on_unregistered_query_for_clients' that allows unregistered queries to execute while logging warnings. This provides a gradual migration path for teams adopting the query registry. Key changes: - Add warn_on_unregistered_query_for_clients config option - Log warnings for unregistered queries from specified clients - Queries execute normally (no errors) when in warning mode - Warnings logged even for clients in allow_any_query_for_clients - Updated RBS type signatures and comprehensive tests - Backward compatible - existing configurations unchanged This enables teams to: - Monitor query usage patterns before enforcing registration - Gradually migrate clients to use registered queries - Maintain visibility during the transition period
bsorbo
force-pushed
the
bsorbo/query-registry-warning-mode
branch
from
e88ba46 to
3bc42d2
Compare
bsorbo
changed the title
Collaborator
|
Superseded by #631. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
warn_on_unregistered_query_for_clientsconfiguration option to the query registry that provides a migration path for clients to move to actually enforcing registration for their queries. With this setting, unregistered queries will continue to execute, but a warning message will be emitted for later inspection.How tested?