Remove unneeded work around for invalid operations from indexer. #977
+1
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valid `operation` implementations (and all our current implementations) return a non-empty array from `to_datastore_bulk`. The docs on bulk indicate that every valid operation has a non-empty bulk representation: https://docs.opensearch.org/latest/api-reference/document-apis/bulk/#request-body We don't need to keep a work around in place for invalid operations. And if we did, I don't think siltently ignoring them is the best approach.
myronmarston
requested review from
BrianSigafoos-SQ,
ayousufi,
bsorbo,
jwils,
jwondrusch,
lancethomps,
nicolewoch and
thomasmahoney
as code owners
jwils
approved these changes
Jan 18, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Valid
operationimplementations (and all our current implementations) return a non-empty array fromto_datastore_bulk. The docs on bulk indicate that every valid operation has a non-empty bulk representation:https://docs.opensearch.org/latest/api-reference/document-apis/bulk/#request-body
We don't need to keep a work around in place for invalid operations. And if we did, I don't think siltently ignoring them is the best approach.