Consolidate duplicate new_primary_indexing_operation helpers #978
+64
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved three duplicate implementations into a shared PrimaryIndexingOperationSupport module in spec/support. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
jwils
requested review from
BrianSigafoos-SQ,
ayousufi,
bsorbo,
jwondrusch,
lancethomps,
myronmarston,
nicolewoch and
thomasmahoney
as code owners
myronmarston
approved these changes
Jan 19, 2026
Collaborator
myronmarston
left a comment
myronmarston
left a comment
There was a problem hiding this comment.
LGTM once you get the build to green. The spec failure looks transient (and ES/OS exception). The standard failures need to be addressed (via be standardrb --fix), though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved three duplicate implementations into a shared PrimaryIndexingOperationSupport module in spec/support.
🤖 Generated with Claude Code