Add extension_data to QueryDetailsTracker for query registry logging #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myronmarston
requested review from
BrianSigafoos-SQ,
ayousufi,
bsorbo,
jwils,
jwondrusch,
lancethomps,
nicolewoch and
thomasmahoney
as code owners
jwils
approved these changes
Jan 19, 2026
...ph-query_registry/lib/elastic_graph/query_registry/query_validators/for_registered_client.rb
Outdated
Show resolved
Hide resolved
elasticgraph-graphql/spec/unit/elastic_graph/graphql/query_details_tracker_spec.rb
Show resolved
Hide resolved
myronmarston
force-pushed
the
myron/query-registration-status-logging
branch
from
9d071f5 to
2d80f1f
Compare
Add mechanism for GraphQL extensions to log additional data in ElasticGraphQueryExecutorQueryDuration message. Query registry uses this to log query_registration_status with values: - matched_registered_query: exact match of registered query - differing_registered_query: same operation name but query differs - unregistered_query: client registered, no query with that name - unregistered_client: client not registered at all Key changes: - Add extension_data field and []= method to QueryDetailsTracker - Merge extension_data into QueryExecutor log output - Update query validators to return registration_status as 3rd element - Update GraphQL extension to set query_registration_status in tracker - Optimize ForRegisteredClient to check operation name before canonicalization for better performance - Use selected_operation_name instead of operation_name to correctly identify single-operation queries Co-Authored-By: Claude <noreply@anthropic.com>
myronmarston
force-pushed
the
myron/query-registration-status-logging
branch
from
2d80f1f to
fc60870
Compare
jwils
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ElasticGraphQueryExecutorQueryDurationmessagequery_registration_statuswith values:matched_registered_query: exact match of registered querydiffering_registered_query: same operation name but query differsunregistered_query: client registered, no query with that nameunregistered_client: client not registered at allSupersedes #631 with a cleaner implementation based on PR feedback.
Test plan
🤖 Generated with Claude Code