Re-land #30 substitution work on main - #32
Merged
Conversation
migrate now executes the planner's classified route: a blocking submitted form runs as the safer native sequence (reported in the verdict's executed_sql), --force requires typing the resolved schema-qualified table and is audit-logged, and every typed executor outcome carries a stable string code (executor.OutcomeCode) so orchestrators branch on one vocabulary, not prose.
…ptNative A forced submitted form was routed through RunSequence, whose shape admission categorically refused it before any DB access — the documented --force CREATE INDEX case could never execute. Forced runs now bypass sequence admission and execute as one blind bounded attempt. Executor admission refusals (unnamed index, IF NOT EXISTS, undriven DETACH PARTITION CONCURRENTLY) now surface as typed refusal verdicts instead of raw operational errors, invalid-index debris is never masked as a plain budget refusal, refused forced attempts keep the machine-readable forced flag, and the statement-budget advice is tailored for submitted online idioms.
…to kiran01bm/p3-4-substitution * origin/kiran01bm/p3-2-native-idioms: surface retry attempts and prove lock-retry flag wiring feat(executor): lock_timeout + bounded retry for native DDL # Conflicts: # internal/cli/cli.go # internal/cli/migrate.go # internal/cli/migrate_test.go
…angelog Review follow-ups on the substitution PR: a mid-sequence failure was only a typed error on stderr, so automation could not distinguish nothing committed from a scaffold left behind. Execution failures now end in a third verdict outcome (failed, still exit 1) carrying executor.OutcomeCode, the failed step, and the committed prefix. The changelog calls out the intended outcome changes for automation callers.
cli: substitute safer sequences by default, gated --force, stable executor codes
…to kiran01bm/p3-4-mainline * origin/kiran01bm/p3-2-native-idioms: Emit failed verdicts with executor codes and committed prefix; add changelog Map execution failures to refusal verdicts; run forced form via AttemptNative feat(cli): substitute safer sequences by default, gated --force
Kiran01bm
marked this pull request as ready for review
August 13, 2026 10:50
Kiran01bm
requested review from
JashLal,
aparajon,
eeSeeGee,
jayjanssen,
jemiahw and
morgo
as code owners
August 13, 2026 10:50
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-lands the substitution work from #30 onto
main. #30 was approved and merged, but itsbase was the stacked branch
kiran01bm/p3-2-native-idioms(already onmainvia #28), sothe merge stranded the commits off
main. This PR carries the identical, already-reviewedcommits to
main; no new changes.What
migrate, with the audited--forceoverride (gated to substitution-override / rewrite-required / backend-unavailable paths).
failedoutcome carrying the stable executorcode, failed step, and committed prefix in
executed_sql.CHANGELOG.mddocumenting the observable-outcome changes for automation callers.Why
mainmust contain the substitution engine before dependent work (privilege preflightcomposition in #31) can build on it. Content was reviewed and approved in #30.
References