Skip to content

[Do not merge] visual test update demo - #908

Open
edgars-avotins wants to merge 1 commit into
mainfrom
codex/miners-action-menu-bg
Open

[Do not merge] visual test update demo#908
edgars-avotins wants to merge 1 commit into
mainfrom
codex/miners-action-menu-bg

Conversation

@edgars-avotins

Copy link
Copy Markdown
Contributor

🤖 Reviewable diff: +1/-1 across 1 file (excludes generated, test, and story files).

Summary

This PR gives the miners action menu a slightly more distinct elevated surface so the desktop menu reads as a clearer overlay against the miners page. It also refreshes the affected ProtoFleet onboarding visual baseline so the Linux-verified screenshot matches the intended UI change.

How it works

The shared RowActionsMenu desktop popover now applies the bg-surface-5 token to the menu container instead of relying on the previous default surface styling. Because the onboarding visual spec captures the first single-miner actions menu, rerunning the Linux snapshot refresh flow updated the checked-in expected desktop image for that menu state.

Diagrams

flowchart LR
  A["Miner row actions trigger"] --> B["RowActionsMenu desktop popover"]
  B --> C["Apply bg-surface-5 menu surface"]
  C --> D["Onboarding visual spec captures updated menu"]
  D --> E["Desktop baseline snapshot refreshed"]
Loading

Areas of the code involved

Area / package / file What changed Why it matters for review
client/src/protoFleet/features/fleetManagement/components/RowActionsMenu/RowActionsMenu.tsx Added the bg-surface-5 class to the desktop actions popover container. This is the only product code change and determines the visible menu background.
client/e2eTests/protoFleet/spec/onboardingVisual.spec.ts-snapshots/visual/single-miner-actions-menu-desktop.png Refreshed the checked-in expected desktop onboarding visual snapshot. Confirms the Linux-verified visual baseline matches the intended menu styling change.

Key technical decisions & trade-offs

  • Apply the color token at the shared row-actions popover level instead of a miner-specific component so the existing single-miner menu screenshot updates through the real shared surface.
  • Refresh only the affected desktop snapshot instead of broad baseline churn, keeping the visual-review scope tight.

Testing & validation

  • Ran ./node_modules/.bin/eslint src/protoFleet/features/fleetManagement/components/RowActionsMenu/RowActionsMenu.tsx.
  • Ran npm run test:e2e:visual:update:linux -- --confirm-overwrite; desktop passed and refreshed the expected snapshot, while the initial mobile run hit a non-reproducible miners-list startup flake before the capture step.
  • Reran npm run test:e2e:visual:update:linux -- --confirm-overwrite --project=mobile --skip-build; mobile then passed cleanly.
  • Visually reviewed the refreshed desktop snapshot before committing.

@edgars-avotins
edgars-avotins requested a review from a team as a code owner August 11, 2026 08:11
Copilot AI lite review requested due to automatic review settings August 11, 2026 08:11
@github-actions github-actions Bot added javascript Pull requests that update javascript code client labels Aug 11, 2026
@github-actions github-actions Bot added the review-policy: needs-review Managed by the Review Policy workflow. label Aug 11, 2026
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

🔐 Codex Security Review

Note: This is an automated security-focused code review generated by Codex.
It should be used as a supplementary check alongside human review.
False positives are possible - use your judgment.

Scope summary

  • Reviewed pull request diff only (2c7f1b9e9da02c30e4d8032b1962c70e6f1c7c32...fbc68ffbca54cce609e488fffbc0e4292f00d3d7, exact PR three-dot diff)
  • Model: gpt-5.6-sol

💡 Click "edited" above to see previous reviews for this PR.


Review Summary

Overall Risk: NONE

Findings

No security, correctness, or reliability findings.

Notes

The diff only changes the row-actions popover background to an existing theme token and updates its visual snapshot. No authentication, data handling, command execution, network, plugin, protobuf, or mining-pool behavior is affected.


Generated by Codex Security Review |
Triggered by: @edgars-avotins |
Review workflow run

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ProtoFleet miners row actions desktop popover styling so the menu reads as a clearer elevated overlay by applying the bg-surface-5 token, and refreshes the corresponding onboarding visual baseline to match the intended UI change.

Changes:

  • Apply !bg-surface-5 to the desktop RowActionsMenu popover container.
  • Update the onboarding visual snapshot for the single-miner desktop actions menu state.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
client/src/protoFleet/features/fleetManagement/components/RowActionsMenu/RowActionsMenu.tsx Sets the desktop popover container background to bg-surface-5 to improve visual separation from the miners page.
client/e2eTests/protoFleet/spec/onboardingVisual.spec.ts-snapshots/visual/single-miner-actions-menu-desktop.png Refreshes the expected onboarding visual snapshot to reflect the updated menu surface styling.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@edgars-avotins edgars-avotins changed the title Adjust miners action menu background [Do not merge] Adjust miners action menu background Aug 11, 2026
@edgars-avotins edgars-avotins changed the title [Do not merge] Adjust miners action menu background [Do not merge] visual test update demo Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client javascript Pull requests that update javascript code review-policy: needs-review Managed by the Review Policy workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants