[Do not merge] visual test update demo - #908
Conversation
🔐 Codex Security Review
Review SummaryOverall Risk: NONE FindingsNo security, correctness, or reliability findings. NotesThe diff only changes the row-actions popover background to an existing theme token and updates its visual snapshot. No authentication, data handling, command execution, network, plugin, protobuf, or mining-pool behavior is affected. Generated by Codex Security Review | |
There was a problem hiding this comment.
Pull request overview
Updates the ProtoFleet miners row actions desktop popover styling so the menu reads as a clearer elevated overlay by applying the bg-surface-5 token, and refreshes the corresponding onboarding visual baseline to match the intended UI change.
Changes:
- Apply
!bg-surface-5to the desktopRowActionsMenupopover container. - Update the onboarding visual snapshot for the single-miner desktop actions menu state.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| client/src/protoFleet/features/fleetManagement/components/RowActionsMenu/RowActionsMenu.tsx | Sets the desktop popover container background to bg-surface-5 to improve visual separation from the miners page. |
| client/e2eTests/protoFleet/spec/onboardingVisual.spec.ts-snapshots/visual/single-miner-actions-menu-desktop.png | Refreshes the expected onboarding visual snapshot to reflect the updated menu surface styling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
🤖 Reviewable diff: +1/-1 across 1 file (excludes generated, test, and story files).
Summary
This PR gives the miners action menu a slightly more distinct elevated surface so the desktop menu reads as a clearer overlay against the miners page. It also refreshes the affected ProtoFleet onboarding visual baseline so the Linux-verified screenshot matches the intended UI change.
How it works
The shared
RowActionsMenudesktop popover now applies thebg-surface-5token to the menu container instead of relying on the previous default surface styling. Because the onboarding visual spec captures the first single-miner actions menu, rerunning the Linux snapshot refresh flow updated the checked-in expected desktop image for that menu state.Diagrams
Areas of the code involved
client/src/protoFleet/features/fleetManagement/components/RowActionsMenu/RowActionsMenu.tsxbg-surface-5class to the desktop actions popover container.client/e2eTests/protoFleet/spec/onboardingVisual.spec.ts-snapshots/visual/single-miner-actions-menu-desktop.pngKey technical decisions & trade-offs
Testing & validation
./node_modules/.bin/eslint src/protoFleet/features/fleetManagement/components/RowActionsMenu/RowActionsMenu.tsx.npm run test:e2e:visual:update:linux -- --confirm-overwrite; desktop passed and refreshed the expected snapshot, while the initial mobile run hit a non-reproducible miners-list startup flake before the capture step.npm run test:e2e:visual:update:linux -- --confirm-overwrite --project=mobile --skip-build; mobile then passed cleanly.