feat(github): name the operator on a control request the data plane records - #1020
Draft
aparajon wants to merge 1 commit into
Draft
feat(github): name the operator on a control request the data plane records#1020aparajon wants to merge 1 commit into
aparajon wants to merge 1 commit into
Conversation
…ecords The control RPCs carried no operator identity, so every durable control request recorded by the plane serving the command named the forwarding path instead of the person who issued it. That name is what the apply log and the PR notice for an accepted-but-unapplied command show. The five control RPCs that record a durable request now carry the caller the accepting plane resolved, and a drive forwarding an operator's queued cutover or start passes on the requester already stored with it. A request that arrives without one still names the forwarding path rather than inventing a person. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #967.
Why this matters
A durable control request names who asked for the operation, and that name is what the apply log and the "command not applied" notice show an operator. But the control RPCs carried no caller, so whenever the plane that recorded the request was not the plane the operator talked to, the row named the RPC path instead of the person. For volume that was true even in a single deployment, because the request is only ever recorded by the serving plane.
What it does
calleron the five control requests that record a durable row: cutover, stop, cancel, start, volume. The accepting plane sets the identity it already resolved for the apply log.volumeresolved the caller for its log line only; it now resolves once and uses it for both the log and the request, matching every other control path.Revert and skip-revert are unchanged: their durable rows are recorded by the accepting plane, which already has the caller.
🤖 Generated with Claude Code