Mitigate endless loop broken pipe error#143
Open
tb205gti wants to merge 1 commit into
Open
Conversation
The code can end up in an endless loop if a broken pipe is experienced in the _fwrite function. This is a rudimentary mitigation by counting the iterations and comparing it to the buffer_length. If the iterations are double the buffer_length, there is a high risk that it is stuck in an endless loop. ``` PHP Notice: fwrite(): send of 2013 bytes failed with errno=32 Broken pipe in /phpMQTT.php on line 435 ```
|
I can confirm the bug, I will use this patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code can end up in an endless loop if a broken pipe is experienced in the _fwrite function. This is a rudimentary mitigation by counting the iterations and comparing it to the buffer_length. If the iterations are double the buffer_length, there is a high risk that it is stuck in an endless loop.