fix: apple host.docker.internal DNS hint + Hermes context mount (#118, #119)#126
Open
hggz wants to merge 2 commits into
Open
fix: apple host.docker.internal DNS hint + Hermes context mount (#118, #119)#126hggz wants to merge 2 commits into
hggz wants to merge 2 commits into
Conversation
…, #119) Warn on HARNESS_CONTAINER_RUNTIME=apple when host.docker.internal is not registered via container system dns, document the one-time setup, mount global AGENTS.md into /workspace for Hermes, and skip PTY e2e tests when macOS bsd script lacks util-linux -qfec. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HARNESS_CONTAINER_RUNTIME=apple, harness checkscontainer system dns listand prints a one-time setup command whenhost.docker.internalis missing (LM Studio / local gateway reachability). Documents the Apple-recommendedcontainer system dns create … --localhost 203.0.113.113flow in README.HermesAdapter.contextDir()now returns/workspaceso globally mountedAGENTS.md/CLAUDE.mdland where Hermes actually reads project context (not~/.hermes).scriptlacks util-linux-qfec; fix “container absent from PATH” test when realcontaineris on PATH; conditional test for the DNS warning.Test plan
pnpm buildnode --test tests/e2e/runtime.test.mjs— 15/15 on macOS arm64:/workspace/AGENTS.md)sudo container system dns create host.docker.internal --localhost 203.0.113.113Closes #118, closes #119.
cc @capotej
Made with Cursor