Skip to content

Underline #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Underline #34

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d387c1f
underlines are now detected and the underline style is marked in the …
Feb 22, 2016
0b57b46
underlines are now detected and the underline style is marked in the …
Feb 22, 2016
e0db9b3
Merge branch 'underline' of github.com:alanbacon/python-ooxml into un…
Sep 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ooxml/parse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,13 @@ def _name(name):

def is_on(value):
return value in ['true', 'on', '1']

def is_on_underline(value):
# values gained from http://www.datypic.com/sc/ooxml/a-w_val-18.html
return value in ['single', 'words', 'double', 'thick', 'dotted',
'dottedHeavy', 'dash', 'dashedHeavy', 'dashLong',
'dashLongHeavy', 'dotDash', 'dashDotHeavy', 'dotDotDash',
'dashDotDotHeavy', 'wave', 'wavyHeavy', 'wavyDouble']


def parse_previous_properties(document, paragraph, prop):
Expand Down Expand Up @@ -85,8 +92,8 @@ def parse_previous_properties(document, paragraph, prop):
u = prop.find(_name('{{{w}}}u'))

if u is not None:
if is_on(u.attrib.get(_name('{{{w}}}val'), 'on')):
paragraph.rpr['u'] = True
if is_on_underline(u.attrib.get(_name('{{{w}}}val'), 'on')):
paragraph.rpr['u'] = u.attrib.get(_name('{{{w}}}val'), 'on')

# parse underline
strike = prop.find(_name('{{{w}}}strike'))
Expand Down