Add flushing support for gzip compressor#116
Open
sidhant007 wants to merge 3 commits intoboostorg:developfrom
Open
Add flushing support for gzip compressor#116sidhant007 wants to merge 3 commits intoboostorg:developfrom
sidhant007 wants to merge 3 commits intoboostorg:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #116 +/- ##
===========================================
+ Coverage 68.96% 69.00% +0.04%
===========================================
Files 80 80
Lines 3444 3462 +18
Branches 1027 1033 +6
===========================================
+ Hits 2375 2389 +14
+ Misses 452 451 -1
- Partials 617 622 +5
Continue to review full report at Codecov.
|
Author
|
Hey @jeking3, can you kindly review this PR |
|
Yeet this please Worth noting, I guess, that you can use new/delete to force the desired behavior. Any chance to generalize this for the other compressors? I'll have a look at how hard it is to add zstd. |
|
Hi can @jeking3 or someone kindly review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses Z_FULL_FLUSH at the point where flushing is done. Therefore it enables the user to read data between any two flush points.
Fixes 1656 for Gzip Filters. More context here
Relies on Z_BUF_ERROR to determine when to stop deflating.