Skip to content

[BOT] Bump Velox version - #731

Merged
zhztheplayer merged 2 commits into
mainfrom
bump-velox-537
Jul 23, 2026
Merged

[BOT] Bump Velox version#731
zhztheplayer merged 2 commits into
mainfrom
bump-velox-537

Conversation

@velox4j-bot

@velox4j-bot velox4j-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Update Velox to latest. Diff: facebookincubator/velox@9a52d0e...4487e44

@velox4j-bot
velox4j-bot Bot enabled auto-merge (squash) July 22, 2026 06:26
@zhztheplayer

Copy link
Copy Markdown
Contributor

@copilot check CI

auto-merge was automatically disabled July 22, 2026 21:22

Head branch was pushed to by a user without write access

Copilot AI commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@copilot check CI

Both Java UT and C++ UT were failing with the same CMake error from the bundled glog dependency:

CMake Error at build/_deps/glog-src/cmake/GetCacheVariables.cmake:2 (cmake_policy):
  Compatibility with CMake < 3.5 has been removed from CMake.
  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

Fixed in the latest commit by adding set(CMAKE_POLICY_VERSION_MINIMUM 3.5) to src/main/cpp/CMakeLists.txt. This tells CMake to allow old cmake_policy(VERSION) calls in bundled dependencies like glog that haven't yet updated their minimum CMake version requirement.

Copilot AI requested a review from zhztheplayer July 22, 2026 21:22
@zhztheplayer
zhztheplayer merged commit 51d8b3b into main Jul 23, 2026
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants