Skip to content

Comments

Fix constraint2() call and spelling errors from code review#406

Merged
dellaert merged 2 commits intofeature/gtsam_optimizersfrom
copilot/sub-pr-403
Feb 1, 2026
Merged

Fix constraint2() call and spelling errors from code review#406
dellaert merged 2 commits intofeature/gtsam_optimizersfrom
copilot/sub-pr-403

Conversation

Copy link
Contributor

Copilot AI commented Feb 1, 2026

Addresses review comments from copilot-pull-request-reviewer bot on PR #403.

Changes

  • Logic fix: ConstrainedOptProblem.cpp:80 now calls constraint2() instead of constraint1() twice when processing TwinDoubleExpressionInequality

    // Before: incorrectly called constraint1() for both constraints
    DoubleExpressionInequality::shared_ptr p2 = p->constraint1();
    
    // After: correctly retrieves second constraint
    DoubleExpressionInequality::shared_ptr p2 = p->constraint2();
  • Spelling corrections in comments/docs across 6 files:

    • probelmproblem
    • cosntraints/cosntraintconstraints/constraint
    • constriantconstraint
    • expaned_matexpanded_mat (variable name)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: dellaert <10515273+dellaert@users.noreply.github.com>
@dellaert dellaert marked this pull request as ready for review February 1, 2026 16:16
@dellaert dellaert merged commit 264efd4 into feature/gtsam_optimizers Feb 1, 2026
@dellaert dellaert deleted the copilot/sub-pr-403 branch February 1, 2026 16:17
Copilot AI changed the title [WIP] Remove constrained optimizers and use GTSAM versions Fix constraint2() call and spelling errors from code review Feb 1, 2026
Copilot AI requested a review from dellaert February 1, 2026 16:17
Copilot stopped work on behalf of dellaert due to an error February 1, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants