Fix constraint2() call and spelling errors from code review#406
Merged
dellaert merged 2 commits intofeature/gtsam_optimizersfrom Feb 1, 2026
Merged
Fix constraint2() call and spelling errors from code review#406dellaert merged 2 commits intofeature/gtsam_optimizersfrom
dellaert merged 2 commits intofeature/gtsam_optimizersfrom
Conversation
Merged
Co-authored-by: dellaert <10515273+dellaert@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove constrained optimizers and use GTSAM versions
Fix constraint2() call and spelling errors from code review
Feb 1, 2026
Copilot stopped work on behalf of
dellaert due to an error
February 1, 2026 16:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review comments from copilot-pull-request-reviewer bot on PR #403.
Changes
Logic fix:
ConstrainedOptProblem.cpp:80now callsconstraint2()instead ofconstraint1()twice when processingTwinDoubleExpressionInequalitySpelling corrections in comments/docs across 6 files:
probelm→problemcosntraints/cosntraint→constraints/constraintconstriant→constraintexpaned_mat→expanded_mat(variable name)✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.