test: unskip e2e meta-tx transferAuthorizations tests#1031
Merged
Conversation
Re-enables the 'meta-tx with transfer authorizations' describe block in core-sdk-token-auth.test.ts (12 tests across ERC3009/EIP2612/Permit2 × commitToOffer/commitToConditionalOffer/commitToBuyerOffer/ createOfferAndCommit) and the ERC3009 transferAuthorizations test in meta-tx.test.ts. These were left skipped on main due to a squash-merge interaction between PR #1030 (which added the skips) and PR #1029 (whose un-skips were diff'd against the pre-#1030 base and therefore collapsed to a no-op on the e2e files). Also reverts the meta-tx-gateway image tag to :main now that the bytes[] transferAuthorizations support has landed on the gateway's main branch.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1031 +/- ##
==========================================
+ Coverage 91.66% 91.73% +0.06%
==========================================
Files 182 182
Lines 7764 7764
Branches 1514 1514
==========================================
+ Hits 7117 7122 +5
+ Misses 647 642 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-enables 13 e2e tests that were silently left skipped on `main`:
Also reverts `e2e/docker-compose.yml` meta-tx-gateway image tag from `bump-common-alpha-5` back to `:main` now that the `bytes[]` transferAuthorizations support is on the gateway repo's main.
Why these were skipped
PR #1030 added `.skip` to these tests because the contracts-bump branch (which shipped the new `bytes[]` ABI) could not pass them against the old meta-tx-gateway image. PR #1029 was supposed to un-skip them in the same commit that dropped the `encodeTransferAuthorizationQueue` wrapper.
The un-skips never made it onto `main`. PR #1030 was squash-merged first, putting the skip lines on main. PR #1029 was then squash-merged with a diff computed against the pre-#1030 merge-base — its add-then-remove of the skip lines collapsed to a no-op on the e2e files. `git show <#1029-merge-sha> --stat` confirms zero changes to `e2e/tests/*`. The 13 tests have therefore not been running against the rebuilt gateway image even though everything else is in place.
Test plan
🤖 Generated with Claude Code