fix: short-circuit ensureAllowance when returnTxInfo is set#1034
Merged
Conversation
…Info is set Callers that only need the encoded transaction (e.g. the MCP server) cannot perform the allowance check, which requires a signer. Mirror the existing return-only flow by bypassing ensureAllowance when returnTxInfo is true. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Push the returnTxInfo check down into ensureAllowance so every caller that already plumbs returnTxInfo through (commitToOffer, commitToBuyerOffer, commitToConditionalOffer, createOfferAndCommit, commitToOfferAndRedeemVoucher, commitToConditionalOfferAndRedeemVoucher, createOfferCommitAndRedeem) skips the allowance check uniformly. Avoids the MCP server failure mode where no signer is available to send an ERC20 approve transaction. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
zajck
changed the title
ensureAllowance now widens returnTxInfo to boolean. Pass returnTxInfo: false explicitly when calling approve() so TypeScript picks the TransactionResponse overload (the one with .wait()). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core-sdk(commitToOffer,commitToBuyerOffer,commitToConditionalOffer,createOfferAndCommit,commitToOfferAndRedeemVoucher,commitToConditionalOfferAndRedeemVoucher,createOfferCommitAndRedeem) all supportreturnTxInfo: truefor callers (e.g. the MCP server) that only need the encoded transaction.ensureAllowanceunconditionally, which attempts an ERC20approvetransaction and breaks for callers without a signer.ensureAllowancenow short-circuits whenreturnTxInfois true, and every call site passes the flag through.Test plan
returnTxInfo: trueand an ERC20 exchange token — verify it returns aTransactionRequestwithout hittingensureAllowance/approve.returnTxInfounset /false— verify allowance is still ensured before sending the transaction.🤖 Generated with Claude Code