Skip to content

Update maintainers: replace Mohamed Mahmoud with Andrew McDermott#513

Merged
mergify[bot] merged 1 commit into
bpfman:mainfrom
alebedev87:update-maintainers
May 6, 2026
Merged

Update maintainers: replace Mohamed Mahmoud with Andrew McDermott#513
mergify[bot] merged 1 commit into
bpfman:mainfrom
alebedev87:update-maintainers

Conversation

@alebedev87
Copy link
Copy Markdown
Contributor

No description provided.

@frobware
Copy link
Copy Markdown
Contributor

The CI failure here is unrelated to this PR. It's caused by an upstream change in sigs.k8s.io/controller-runtime.

Makefile:217 installs setup-envtest@latest:

test -s $(LOCALBIN)/setup-envtest || GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest

On 2026-04-22, commit 557c314 (PR #3506) bumped tools/setup-envtest/go.mod to go 1.26.0 as part of the k8s v1.36.0 dep update. CI runs Go 1.25.9 with GOTOOLCHAIN=local, so the install fails:

sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20260424122448-c8b4b9d61fbd requires go >= 1.26.0 (running go 1.25.9; GOTOOLCHAIN=local)

Options:

  1. Pin setup-envtest to a version still on Go 1.25 instead of @latest.
  2. Bump the project's Go toolchain to 1.26.
  3. Drop GOTOOLCHAIN=local so Go can fetch a newer toolchain on demand.

Pinning is the least invasive and removes the "works until upstream moves" footgun.

@alebedev87
Copy link
Copy Markdown
Contributor Author

@frobware: I'm proposing to pin setup-envtest module to a specific version and move it to vendor directory. This way we 1) hard link envtest to the rest of dependencies (k8s, controller-runtime), 2) avoid custom installation of envtest binary into the repository's bin/ and use the go toolset for it.

@frobware
Copy link
Copy Markdown
Contributor

frobware commented May 6, 2026

#516 has merged. This should now pass CI.

@frobware
Copy link
Copy Markdown
Contributor

frobware commented May 6, 2026

/retest

@frobware
Copy link
Copy Markdown
Contributor

frobware commented May 6, 2026

#516 has merged. This should now pass CI.

Once it has been rebased. :)

Signed-off-by: Andrey Lebedev <alebedev@redhat.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@alebedev87 alebedev87 force-pushed the update-maintainers branch from 02cbb37 to 9ccfc97 Compare May 6, 2026 11:57
Copy link
Copy Markdown
Contributor

@frobware frobware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@mergify mergify Bot merged commit a60408c into bpfman:main May 6, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants