Move gen tools to tools/tools.go and use go run#521
Merged
Conversation
Consolidate tool dependency tracking from `hack/tools.go` and Makefile `go install @version` targets into `tools/tools.go` using the blank import pattern. This pins tool versions in `go.mod` and vendors them, matching the pattern already used for `setup-envtest`. Tools moved: `controller-gen`, `register-gen`, `informer-gen`, `lister-gen`, `client-gen`. Makefile now invokes them via `go run` instead of installing to `bin/`. Removed unused `CM_VERIFIER` variable, `CONTROLLER_TOOLS_VERSION`, and `K8S_CODEGEN_VERSION`. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Andrey Lebedev <alebedev@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate tool dependency tracking from
hack/tools.goand Makefilego install @versiontargets intotools/tools.gousing the blank import pattern. This pins tool versions ingo.modand vendors them, matching the pattern already used forsetup-envtest.Tools moved:
controller-gen,register-gen,informer-gen,lister-gen,client-gen. Makefile now invokes them viago runinstead of installing tobin/. Removed unusedCM_VERIFIERvariable,CONTROLLER_TOOLS_VERSION, andK8S_CODEGEN_VERSION.