This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
==========================================
- Coverage 99.95% 99.33% -0.62%
==========================================
Files 107 108 +1
Lines 2056 2101 +45
==========================================
+ Hits 2055 2087 +32
- Misses 1 11 +10
- Partials 0 3 +3
Continue to review full report at Codecov.
|
jayme-github
force-pushed
the
new_fields
branch
from
2c65a4a to
7b93325
Compare
Added the new fields (as of AVMs docs): * WindowOpenEnd * Boost * BoostEnd * Holiday * Summer As this makes the cli output quite long, I've added a verbose option to hide most of the new fields by default.
jayme-github
force-pushed
the
new_fields
branch
from
7b93325 to
32732f8
Compare
Owner
|
Hi @jayme-github, thanks for taking the time to contribute. I will try to look into this PR as soon as I can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the new fields (as of AVMs docs):
As this makes the cli output quite long, I've added a verbose option to hide most of the new fields by default.
Seems like we where working on the same stuff in parallel today. 😄
I'm not sure about the types in model.go. You seem to prefer to parse everything as string and I am not sure why that is. Let me know if you would like to have that changed.
As of the window stuff at least all my devices seem to not report the state properly.