Add support for ActivityResultRegistry in BrowserSwitchClient#127
Add support for ActivityResultRegistry in BrowserSwitchClient#127
Conversation
saperi22
changed the title
browser-switch/src/main/java/com/braintreepayments/api/BrowserSwitchClient.java
Show resolved
Hide resolved
browser-switch/src/main/java/com/braintreepayments/api/BrowserSwitchClient.java
Outdated
Show resolved
Hide resolved
|
I tested the flow and it looks like everything is working correctly! Just a question, I noticed BrowserSwitchClient is created directly in the composable body without |
I haven't put much thought into it since it is in the demo app. |
saralvasquez
left a comment
saralvasquez
left a comment
There was a problem hiding this comment.
Tested everything and it works as normal. Just had a small question for my own knowledge
| when (val startResult = browserSwitchClient.start(this, browserSwitchOptions)) { | ||
| is BrowserSwitchStartResult.Started -> { | ||
| PendingRequestStore.put(this, startResult.pendingRequest) | ||
| MainContent() |
There was a problem hiding this comment.
The changes here make sense to me, but can I ask why you pulled everything into MainContent? Is it just to adhere to compose best practices better?
There was a problem hiding this comment.
Ah, great one.
For compose testing, I wanted to test if we can not rely on the lifecycle methods provided by activity and instead handle everything within compose.
There was a problem hiding this comment.
Ahhhhhhh! Ok yeah that makes a ton of sense. I remember us talking about the lifecycle struggles between activity and compose. Cool
4 participants
Summary of changes
Checklist
Authors