You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi there! First of all, I really loved the project.
Noticed that in the examples, you’re using @ts-ignore because of the custom hooks. This PR address that. It is not be the most elegant solution, but it works well 😬.
With the declared Fn, it doesn’t really work right. TypeScript kinda gets lost (like you can see in the screenshot), and the types for each custom function disappear.
I tweaked it a bit to still use any, but now it checks if the passed value extends Fn.
Also removed the & { length?: never; } and @ts-ignore
@ylyra Thanks for the update! I'll check this over the weekend. The fix might be fine, but I'm weary of using any anywhere, as it can be a slippery slope for loose-type checking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! First of all, I really loved the project.
Noticed that in the examples, you’re using
@ts-ignorebecause of the custom hooks. This PR address that. It is not be the most elegant solution, but it works well 😬.