Skip to content
This repository was archived by the owner on May 5, 2024. It is now read-only.

Implemented FlySystem for FileSystem abstraction - #46

Open
dubcanada wants to merge 1 commit into
brandonsavage:masterfrom
dubcanada:master
Open

Implemented FlySystem for FileSystem abstraction#46
dubcanada wants to merge 1 commit into
brandonsavage:masterfrom
dubcanada:master

Conversation

@dubcanada

Copy link
Copy Markdown

Solves #41

I wasn't exactly sure if this is the best method or not, but it works. Basically I took out the FileStorage interface and replaced it with FlySystem.

@scottrobertson

Copy link
Copy Markdown
Contributor

Thanks for this, shall take a look at it today.

@scottrobertson

Copy link
Copy Markdown
Contributor

Sorry, been very busy. @codeguy can you take a look at this too?

@scottrobertson

Copy link
Copy Markdown
Contributor

I am happy with this as a first step i think.

@dubcanada

Copy link
Copy Markdown
Author

Thoughts?

@codeguy

codeguy commented Sep 3, 2014

Copy link
Copy Markdown
Contributor

I like. @scottrobertson what else do you have in mind?

@scottrobertson

Copy link
Copy Markdown
Contributor

We should pick this up again, sorry i did not respond. Is this still ok to merge?

@bradleyboy

Copy link
Copy Markdown

Coming to this late but one thing to watch out for here is that FlySystem requires PHP 5.4+, while this library is currently baselined at 5.3.

@codeguy

codeguy commented Oct 15, 2014

Copy link
Copy Markdown
Contributor

@bradleyboy Good point. I'm fine bumping the requirements. I'll do that shortly.

@ghost

ghost commented Nov 11, 2014

Copy link
Copy Markdown

@codeguy any update on this?

@ghost

ghost commented Nov 19, 2014

Copy link
Copy Markdown

@codeguy Not to be annoying, but I'm really interested in using this with Flysystem, so I'm just wondering if you plan on merging this? Thanks 😄

@mikealmond

Copy link
Copy Markdown

Any update on this PR?

@tamtamchik

Copy link
Copy Markdown

👍 any ETA when this could possibly be implemented?

@jeremykendall

Copy link
Copy Markdown

Bump.

@kaperys

kaperys commented Jan 15, 2016

Copy link
Copy Markdown

Any update on this?

@napolux

napolux commented Mar 30, 2016

Copy link
Copy Markdown

Hellooooooo.... Is this repo still active?

@solleer

solleer commented Jul 1, 2016

Copy link
Copy Markdown

Will this be merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.