chore(claude): replace agent-framework with hivemind plugin config - #124
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aba64f904c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Resolve SubagentStart hook via "$CLAUDE_PROJECT_DIR" so it works when Claude Code launches from a repository subdirectory. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016U4x5XQEA2zzprEz9BEq5Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repository migrated from the
agent-frameworkClaude Code plugin tohivemind. The migration was applied to the working tree but never committed, and the old plugin's references were never removed — soCLAUDE.mdhas been describing a plugin this repo no longer uses, while the actual configuration sat uncommitted.Removes every
agent-frameworkreferenceCLAUDE.md— the Multi-Agent Governance section is rewritten for hivemind. Agent and skill names were verified against the installed plugin'sagents/andskills/directories rather than recalled; this file is the repository's agent-instruction file, so a name that doesn't exist would silently misroute future sessions. The JSON snippet now also shows the"agent"key, whichsettings.jsonhas always set but the doc never mentioned..claude/settings.json— drops the dead"agent-framework@brenpike": trueenable.docs/performance-todo.md— "a planner or coder agent" named two old plugin agents. Reworded to "an implementing agent" rather than substituting the current plugin's names, so the doc doesn't need editing again after the next migration..claude/settings.local.json(gitignored, not in this diff) — six staleSkill(agent-framework:*)grants removed locally.A working-tree grep now returns zero occurrences outside
.git/.Commits the pending plugin configuration
.gitignoregains.hivemind/and.claude/worktrees/, plus an EOF-newline fix. This is load-bearing: without it, run ledgers and brood worktrees show up as uncommitted repo content..claude/settings.json— the hivemind enable,"agent": "hivemind:overlord", the caveman and codex plugin config, theSubagentStarthook, and the permission allowlist..claude/hooks/caveman-ultra-subagent.sh— previously untracked, and referenced by that hook. Committing the hook config without the script would have broken the repo for any other clone.Two defects fixed along the way
A dead permission rule.
settings.jsoncarriedBash(node /path/to/.claude/plugins/cache/openai-codex/codex/*)—/path/to/is a literal unsubstituted placeholder inherited from a plugin seed template, so the rule matched nothing. It's removed rather than corrected: the machine-correct path would embed an absolute home directory into a public repository. The working rule now lives in the gitignoredsettings.local.json, which is where this repo already keeps per-machine grants.A latent CRLF breakage.
core.autocrlfistrueand the repo had no.gitattributes. Committing the first tracked.shfile without one means a future clone receives#!/usr/bin/env bash\rand the hook fails to execute — a breakage that would never reproduce in the current working tree. A minimal*.sh text eol=lfrule pins it. Deliberately scoped to that one pattern: a broad* text=autoin a repo with existing checked-in CRLF content could rewrite line endings across many files on the next checkout.Verification
grep -rI "agent-framework"over the working tree → zero hitsjq .on both settings files → validbash .claude/hooks/caveman-ultra-subagent.sh | jq .→ emits well-formedSubagentStartJSON, so the hook is functional as committed, not merely presentgit cat-file -p :.claude/hooks/caveman-ultra-subagent.sh→ shebang stored with\n, confirming the.gitattributesrule appliesgit ls-files -s→ hook recorded100755, executable bit preserveddotnet build -c Release→ 0 errors, 3 pre-existing warningsVersioning
None. No files under
src/are touched, so theversion-checkgate short-circuits.Chatter.Rest.Halstays 2.1.0,Chatter.Rest.Hal.CodeGeneratorsstays 0.4.0. No CHANGELOG entries — those track package behavior, not repository tooling.Note
The hivemind seed template still ships the
/path/to/placeholder, so re-runningseed-hiveagainst this repo would re-add the dead rule. Worth fixing upstream inbrenpike/hivemind.