ec: Simplify some internal parsing APIs.#2838
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2838 +/- ##
==========================================
- Coverage 96.51% 96.51% -0.01%
==========================================
Files 206 206
Lines 20530 20520 -10
Branches 518 518
==========================================
- Hits 19814 19804 -10
Misses 599 599
Partials 117 117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Instead of having these wrappers that implicitly allow or disallow zero, just have each call site indicate which behavior it wants.
Most tests aren't actually operating on Montgomery-encoded elements. Separate `consume_elem` and `consume_elem_mont` to make this clearer. No functional change.
briansmith
force-pushed
the
b/uninit-big-endian-limbs
branch
from
ea6f84a to
90da625
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.