Open
Conversation
…h-toggle Add T9 search option and tests
Owner
|
Hello @RichardHum ! Thanks for this cool addition 👍 I've changed the merge base to Please let me know me if you have any difficulty resolving the conflict, I'm happy to help! |
…ction Optimize T9 digit filtering
Author
|
Ah I should have read the documentation more closely. Since the WDS is so large, I'm working on some optimizations before submitting this for final review. |
Add cached T9 digit mapping for catalog searches
Author
|
I added caching on the T9 letter->number mapping so it only needs to run once during the search. Should be ready to merge now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds in proper T9 search, as compared to the current multi-tap approach. I've tested it and I haven't encountered any issues.