fix(postgres): Populate rows_affected in fct_dbt__model_executions for all models#526
Open
afacat wants to merge 3 commits intobrooklyn-data:mainfrom
Open
fix(postgres): Populate rows_affected in fct_dbt__model_executions for all models#526afacat wants to merge 3 commits intobrooklyn-data:mainfrom
afacat wants to merge 3 commits intobrooklyn-data:mainfrom
Conversation
…l_executions Resolves persistent NULL values in rows_affected column across all model execution records on Postgres.
afacat
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
afacat
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
afacat
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
afacat
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
afacat
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
afacat
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
afacat
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
afacat
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
afacat
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
afacat
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
|
@llifoawing I see that you are the last to have committed to main in this repository, would you be able to review this PR? It would be nice if this feature could be merged as it would also benefit my use case. Thanks in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a bug where the rows_affectedcolumn in the fct_dbt__model_executionsmetadata table was persistently NULL for all model executions on PostgreSQL databases.
Update type - breaking / non-breaking
What does this solve?
Resolves persistent NULL values in the rows_affectedcolumn across all model execution records on Postgres. This bug impaired data observability by making it impossible to track the impact of dbt runoperations (e.g., number of rows inserted, updated, or deleted) for any model when using the Postgres adapter.
#485
Outstanding questions
N/A. The fix has been tested and successfully populates the rows_affectedfield as expected.
What databases have you tested with?