fix: handle SampleWindow serialization (#542)#543
Open
Borisdejonge wants to merge 1 commit intobrooklyn-data:mainfrom
Open
fix: handle SampleWindow serialization (#542)#543Borisdejonge wants to merge 1 commit intobrooklyn-data:mainfrom
Borisdejonge wants to merge 1 commit intobrooklyn-data:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #542
When using dbt's
--sampleflag, theSampleWindowobject ininvocation_args_dictis not JSON serializable. This fix handles it the same way
warn_error_optionsishandled - by converting it to a serializable dict before passing to
safe_copy_mapping.Update type - breaking / non-breaking
What does this solve?
Fixes #542 - SampleWindow object not JSON serializable when using
--sampleflag.The
--sampleflag (introduced in dbt for event_time based sampling) adds aSampleWindowPython object toinvocation_args_dict. This object cannot beserialized to JSON, causing
upload_invocationsto fail.Outstanding questions
None - the fix follows the existing pattern used for
warn_error_options.What databases have you tested with?