chore: drop Magento 2.4.6 from the image matrix - #39
Merged
Merged
Conversation
2.4.6 cannot be built any more. Its magento/module-two-factor-auth
1.1.5-p8 requires spomky-labs/otphp ^10.0, and every version matching
that constraint (v10.0.0-v10.0.3) is covered by advisories
PKSA-qv5y-crcz-9nxw and PKSA-kbc7-dq62-pt7d, which are fixed only in
11.4.3. Composer blocks them, so there is no installable set.
Nothing consumes 2.4.6: two-inc/magento-docker builds FROM
ghcr.io/brtkwr/magento:2.4.8 and the chart defaults to 2.4.8.
Also:
- release.yaml built 2.4.6 and tagged it :2.4.6, :latest and the release
version, so :latest pointed at the oldest build. It now builds 2.4.8.
- fail-fast: false on the image matrices, so one version failing no
longer cancels the other jobs and hides their results.
- Delete docker/composer.json, an unused duplicate of the 2.4.6 manifest
(the Dockerfile writes composer.json from composer-${VERSION}.json).
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GFS4uN8RLpnbeLmvmB2Rbu
brtkwr
added this pull request to stack #40
September 18, 2026 13:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #38. Fixes the red main build from #37's merge.
Why 2.4.6 has to go
It is not buildable any more, on any architecture. Magento 2.4.6-p13 pulls
magento/module-two-factor-auth 1.1.5-p8, which requiresspomky-labs/otphp ^10.0. Every version satisfying that constraint is flagged:^10.0resolves to v10.0.0 ... v10.0.3 and nothing else, and the fix landed in 11.4.3. So there is no safe version 2.4.6 can accept —policy.advisories.ignore-idwould not be a workaround, it would be shipping both flaws in the image.This surfaced now rather than earlier because
Dockerfile.basedoesCOPY --from=composer:2, a floating tag. #37 toucheddocker/**, which rebuilt the base for the first time since 3 September and picked up a composer that blocks advisory-affected packages. The breakage predates #37; the rebuild merely exposed it.2.4.7 and 2.4.8 pin newer Magento (
2.4.7-p4,2.4.8) and should resolve against otphp 11.x. This PR is what actually proves that — those four jobs were cancelled by fail-fast last run, so they have never completed.Nothing uses 2.4.6
two-inc/magento-docker/DockerfileFROM ghcr.io/brtkwr/magento:2.4.8charts/magento/values.yamltag: "2.4.8"magento:2.4.6Also in here
release.yamlbuilt only 2.4.6 and tagged it:2.4.6,:latestand the release version — so:latestpointed at the oldest and now-unbuildable image while everything real runs 2.4.8. It now builds 2.4.8.fail-fast: falseon the image matrices. Last run, one arm64 failure cancelled five other jobs and left us with no information about them. These builds are independent; one failing should not hide the rest.docker/composer.json— a byte-identical duplicate ofcomposer-2.4.6.jsonthat nothing reads. The Dockerfile writescomposer.jsoninside the image fromcomposer-${MAGENTO_VERSION}.json, so the context copy was dead weight.Merge order
#38 first, then this. Merging #38 alone would trigger a
docker/**rebuild that still includes 2.4.6 and fails again.🤖 Generated with Claude Code
https://claude.ai/code/session_01GFS4uN8RLpnbeLmvmB2Rbu