Skip to content

Conversation

@ac4ch
Copy link
Contributor

@ac4ch ac4ch commented Mar 10, 2025

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@ac4ch ac4ch requested a review from a team as a code owner March 10, 2025 05:50
@github-actions
Copy link

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 34.51%. Comparing base (3ad6ae4) to head (0644497).

Files with missing lines Patch % Lines
actions/v2/users/address.go 64.86% 10 Missing and 3 partials ⚠️
api/gen.api.go 0.00% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #958   +/-   ##
=======================================
  Coverage   34.50%   34.51%           
=======================================
  Files         437      438    +1     
  Lines       20826    20874   +48     
=======================================
+ Hits         7186     7204   +18     
- Misses      13041    13066   +25     
- Partials      599      604    +5     
Flag Coverage Ξ”
unittests 34.51% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
api/gen.models.go 0.00% <ΓΈ> (ΓΈ)
api/gen.api.go 0.00% <0.00%> (ΓΈ)
actions/v2/users/address.go 64.86% <64.86%> (ΓΈ)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 3ad6ae4...0644497. Read the comment docs.

πŸš€ New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ac4ch ac4ch force-pushed the feat/SPV-1548/v2_user_create_address branch from 42b83e9 to 0644497 Compare March 10, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants