LND: Simple channel closing implementation#37
Open
Bobface wants to merge 6 commits into
Open
Conversation
Adds a `CloseChannel` method to `LndClient` which delegates to the existing `LndSwaggerClient.CloseChannelAsync` method.
|
@NicolasDorier can you review? thanks! |
Member
|
can you ad a test |
|
@NicolasDorier AFAIU there are no tests for opening channels ( |
Member
|
Do not test channel open, test channel close. Look the tests, I setup channel already, just close one of those after. Those LN implementation always break their shit at every update. Without test, this PR will work for 2 months and we would not know it. |
Thanks for the info. Thing is, I looked at the tests and didn't find the channel setup anywhere, can you clarify exactly where's this please? |
|
Hehe, that file is under the namespace I'll have a look, thanks! |
In fact its namespace was BTCPayServer.Lightning.Tests so it was simply misplaced.
Because this way it matches better with the LN API, and is easier to find.
|
@NicolasDorier why is CI not running for the PR? |
Member
|
Somehow was disabled. Can you try to re-commit? |
Not sure if we should add this as the Dispose() method of the test class actually: https://stackoverflow.com/a/33516224/544947
knocte
force-pushed
the
lnd-close-channel
branch
from
c348dfd to
aea9e9d
Compare
Member
|
does not pass |
|
Yep I know, not sure why, I'll investigate later. |
Member
|
@knocte ^ |
knocte
pushed a commit
to nblockchain/geewallet
that referenced
this pull request
Oct 19, 2020
BTCPayServer.Lightning does currently not support closing channels with LND. There is an open PR which implements this feature: btcpayserver/BTCPayServer.Lightning#37 Until this PR is merged we use the compiled DLLs with this feature. Afterwards this commit can be dropped and the Nuget package versions can be updated to the latest version which has the PR merged.
knocte
pushed a commit
to nblockchain/geewallet
that referenced
this pull request
Feb 15, 2021
BTCPayServer.Lightning does currently not support closing channels with LND. There is an open PR which implements this feature: btcpayserver/BTCPayServer.Lightning#37 Until this PR is merged we use the compiled DLLs with this feature. Afterwards this commit can be dropped and the Nuget package versions can be updated to the latest version which has the PR merged.
knocte
pushed a commit
to nblockchain/geewallet
that referenced
this pull request
Feb 15, 2021
BTCPayServer.Lightning does currently not support closing channels with LND. There is an open PR which implements this feature: btcpayserver/BTCPayServer.Lightning#37 Until this PR is merged we use the compiled DLLs with this feature. Afterwards this commit can be dropped and the Nuget package versions can be updated to the latest version which has the PR merged.
knocte
pushed a commit
to nblockchain/geewallet
that referenced
this pull request
Feb 16, 2021
BTCPayServer.Lightning does currently not support closing channels with LND. There is an open PR which implements this feature: btcpayserver/BTCPayServer.Lightning#37 Until this PR is merged we use the compiled DLLs with this feature. Afterwards this commit can be dropped and the Nuget package versions can be updated to the latest version which has the PR merged.
knocte
pushed a commit
to nblockchain/geewallet
that referenced
this pull request
Feb 16, 2021
BTCPayServer.Lightning does currently not support closing channels with LND. There is an open PR which implements this feature: btcpayserver/BTCPayServer.Lightning#37 Until this PR is merged we use the compiled DLLs with this feature. Afterwards this commit can be dropped and the Nuget package versions can be updated to the latest version which has the PR merged.
knocte
pushed a commit
to nblockchain/geewallet
that referenced
this pull request
Feb 16, 2021
BTCPayServer.Lightning does currently not support closing channels with LND. There is an open PR which implements this feature: btcpayserver/BTCPayServer.Lightning#37 Until this PR is merged we use the compiled DLLs with this feature. Afterwards this commit can be dropped and the Nuget package versions can be updated to the latest version which has the PR merged.
knocte
pushed a commit
to nblockchain/geewallet
that referenced
this pull request
Feb 16, 2021
BTCPayServer.Lightning does currently not support closing channels with LND. There is an open PR which implements this feature: btcpayserver/BTCPayServer.Lightning#37 Until this PR is merged we use the compiled DLLs with this feature. Afterwards this commit can be dropped and the Nuget package versions can be updated to the latest version which has the PR merged.
knocte
added a commit
to nblockchain/geewallet
that referenced
this pull request
Feb 16, 2021
BTCPayServer.Lightning does currently not support closing channels with LND. There is an open PR which implements this feature: btcpayserver/BTCPayServer.Lightning#37 Until this PR is merged we use the compiled DLLs with this feature. Afterwards this commit can be dropped and the Nuget package versions can be updated to the latest version which has the PR merged.
knocte
pushed a commit
to nblockchain/geewallet
that referenced
this pull request
Feb 17, 2021
BTCPayServer.Lightning does currently not support closing channels with LND. There is an open PR which implements this feature: btcpayserver/BTCPayServer.Lightning#37 Until this PR is merged we use the compiled DLLs with this feature. Afterwards this commit can be dropped and the Nuget package versions can be updated to the latest version which has the PR merged.
knocte
added a commit
to nblockchain/geewallet
that referenced
this pull request
Feb 17, 2021
BTCPayServer.Lightning does currently not support closing channels with LND. There is an open PR which implements this feature: btcpayserver/BTCPayServer.Lightning#37 Until this PR is merged we use the compiled DLLs with this feature. Afterwards this commit can be dropped and the Nuget package versions can be updated to the latest version which has the PR merged.
Contributor
|
This one needs rebasing :) |
|
@aarani do we need this? |
Contributor
|
I think it would make sense to coordinate it with #84 or integrate the updates there. |
NicolasDorier
force-pushed
the
master
branch
from
1d37a9c to
edb9ce3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
CloseChannelmethod toLndClientwhich delegates to the existingLndSwaggerClient.CloseChannelAsyncmethod.