chore: add retry configuration options for http requests#198
Draft
duyhungtnn wants to merge 12 commits intomasterfrom
Draft
chore: add retry configuration options for http requests#198duyhungtnn wants to merge 12 commits intomasterfrom
duyhungtnn wants to merge 12 commits intomasterfrom
Conversation
Introduce promiseRetriable with a RetryPolicy and ShouldRetryFn, supporting linear (default) and constant backoff strategies. Implements a retry loop honoring maxRetries and delay, a sleep helper, and backoff delay calculation. Add AVA + sinon tests validating successful retries, delay behavior, exceeding max retries, shouldRetry gating, mid-sequence stop, and both linear and constant backoff strategies.
aa2a4ca to
5f3639e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#199
This pull request introduces a robust and configurable retry mechanism for HTTP requests, including support for the
Retry-Afterheader, exponential backoff with jitter, and comprehensive configuration validation and defaults. It also adds extensive unit tests to ensure correct parsing and propagation of retry-related logic throughout the codebase.Retry logic and error handling improvements:
promiseRetriableutility insrc/utils/promiseRetriable.tsthat provides generic, configurable retry logic with exponential backoff and jitter, as well as logic to respect theRetry-Afterheader and classify retryable errors and status codes.InvalidStatusErrorclass insrc/objects/errors.tsto include an optionalretryAfterMsproperty, and added aparseRetryAfterfunction to parse both delta-seconds and HTTP-date formats from theRetry-Afterheader.src/api/client.tsto parse theRetry-Afterheader from error responses and propagate it viaInvalidStatusError, ensuring that retry logic can use this information. [1] [2]Configuration and validation:
maxRetries,retryInitialInterval,retryMaxInterval) to theBKTConfiginterface insrc/config.ts, with sensible defaults and validation logic to handle negative or inconsistent values. [1] [2] [3] [4] [5]