-
Notifications
You must be signed in to change notification settings - Fork 35
Feature flags #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
richardelms
wants to merge
5
commits into
integration/uplift-2025
Choose a base branch
from
featureFlags
base: integration/uplift-2025
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature flags #247
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| package com.bugsnag; | ||
|
|
||
| import com.bugsnag.serialization.Expose; | ||
|
|
||
| import java.util.Objects; | ||
|
|
||
| /** | ||
| * Represents a feature flag with a name and optional variant. | ||
| * Feature flags can be used to annotate events with information about | ||
| * active experiments or A/B tests. | ||
| */ | ||
| public class FeatureFlag { | ||
| private final String name; | ||
| private final String variant; | ||
|
|
||
| /** | ||
| * Create a feature flag with a name and no variant. | ||
| * | ||
| * @param name the name of the feature flag | ||
| */ | ||
| public FeatureFlag(String name) { | ||
| this(name, null); | ||
| } | ||
|
|
||
| /** | ||
| * Create a feature flag with a name and variant. | ||
| * | ||
| * @param name the name of the feature flag | ||
| * @param variant the variant of the feature flag (can be null) | ||
| */ | ||
| public FeatureFlag(String name, String variant) { | ||
| if (name == null || name.isEmpty()) { | ||
| throw new IllegalArgumentException("Feature flag name cannot be null or empty"); | ||
| } | ||
| this.name = name; | ||
| this.variant = variant; | ||
| } | ||
|
|
||
| /** | ||
| * Get the name of the feature flag. | ||
| * | ||
| * @return the feature flag name | ||
| */ | ||
| @Expose | ||
| public String getName() { | ||
| return name; | ||
| } | ||
|
|
||
| /** | ||
| * Get the variant of the feature flag. | ||
| * | ||
| * @return the feature flag variant, or null if not set | ||
| */ | ||
| @Expose | ||
| public String getVariant() { | ||
| return variant; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object obj) { | ||
| if (this == obj) { | ||
| return true; | ||
| } | ||
| if (obj == null || getClass() != obj.getClass()) { | ||
| return false; | ||
| } | ||
| FeatureFlag that = (FeatureFlag) obj; | ||
| return Objects.equals(name, that.name) && Objects.equals(variant, that.variant); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(name, variant); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "FeatureFlag{name='" + name + "', variant='" + variant + "'}"; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should avoid throwing exceptions in these cases. We could avoid it by either making these constructors package-protected (rather than public API), or by replacing them (publicly) with a factory method:
nullability annotations included for clarity