handle both Unix and Windows line endings #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed split('\n') to split(/\r?\n/) to handle both Unix and Windows line endings
- Added .trim() to each line to remove any remaining whitespace including \r
cabana8471-arch
added a commit
to cabana8471-arch/design-os
that referenced
this pull request
Dec 29, 2025
…ons (6 fixes) FIXES: - export-product.md: Added Rule 4 abbreviation note in example prompts - agents.md: Added INCLUDE_SHELL note to Foundation Milestone Definition - agents.md: Added hookify/README.md reference in Full Documentation - agents.md: Documented SKILL.md custom format (non-standard frontmatter) - section/clarifying-questions.md: Renamed to "Section-Specific Backend Logic" - data-model.md: Added cross-reference to agents.md Four Pillars FALSE POSITIVES IDENTIFIED (11): - Issues buildermethods#1, buildermethods#2, buildermethods#4-7, buildermethods#10, buildermethods#12, buildermethods#14, buildermethods#15, buildermethods#17 already properly implemented MODIFIED FILES: - .claude/commands/design-os/export-product.md - .claude/commands/design-os/data-model.md - .claude/templates/design-os/section/clarifying-questions.md - agents.md - FORK_CHANGELOG.md 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
cabana8471-arch
added a commit
to cabana8471-arch/design-os
that referenced
this pull request
Jan 3, 2026
HIGH (1): - Fix validation-patterns.md completeness percentages (8% → 50%) MEDIUM (8): - Add conditional check for --skip-validation warning (buildermethods#2) - Use $RANDOM instead of date +%N for macOS compatibility (buildermethods#3) - Add mkdir -p product/ before context file creation (buildermethods#4) - Increase minimum file size validation to 1000 bytes (buildermethods#9) - Fix grep patterns with trailing space to prevent false matches (buildermethods#10, buildermethods#11) - Align validation-patterns.md percentages with command-reference (buildermethods#16) - Add word count (min 20) and placeholder validation (buildermethods#19) LOW (11): - Remove Mode options table duplication (buildermethods#5) - Remove Question counts table duplication (buildermethods#6) - Update phase file versions to v1.0.1 (buildermethods#7) - Improve variable order documentation (buildermethods#8) - Verify referenced files exist (buildermethods#12) - Add font preferences guidance (buildermethods#13) - Add cross-reference filtering test cases (buildermethods#14) - Document audit+stage interaction with filtered example (buildermethods#15) - Clarify AskUserQuestion multiselect usage (buildermethods#17) - Translate Romanian notes to English (buildermethods#18) - Add minimal question count (~29) to main file (#20) Version bumps: - product-interview.md: v1.3.5 → v1.3.6 - All phase files: v1.0.0 → v1.0.1 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause: Windows uses \r\n (CRLF) line endings. When splitting by \n, each line retained the trailing \r, causing the regex pattern /^###\s+(\d+).\s*(.+)$/ to fail matching.
Changes:
Changed md.split('\n') to md.split(/\r?\n/) to split on both line ending types
Added .trim() to each line to remove any remaining whitespace including \r