Skip to content

Conversation

@TinaTyf
Copy link

@TinaTyf TinaTyf commented Jun 24, 2025

Correction of business logic

Correction of business logic
@TinaTyf TinaTyf marked this pull request as ready for review June 24, 2025 02:36
@TinaTyf
Copy link
Author

TinaTyf commented Jun 25, 2025

According to the semantic definition of IfcSegmentedReferenceCurve and the example Linear Placement Of Signal, the correct logic could be : IfcCompositeCurve ( Horizontal Segments ) → IfcGradientCurve ( Vertical Segments ) .BaseCurve ( Horizontal Segments ) → IfcSegmentedReferenceCurve ( Cant Segments ).BaseCurve ( Horizontal + Vertical Segments )
linear placement of signal

@aothms aothms requested a review from evandroAlfieri June 25, 2025 10:40
@aothms
Copy link
Collaborator

aothms commented Jun 25, 2025

IfcSegmentedReferenceCurve:Segments -> IfcCurveSegment_1 -> Curve_Segment_Vertical

You're right. Pairing Vertical with IfcSegmentedReferenceCurve is definitely a mistake.

@berlotti
Copy link
Member

Is this something we can change? Or is it something that needs to be fixed in an update of 4.3?
We cannot just make changes in a published standard.... even though they are clear mistakes.

@aothms
Copy link
Collaborator

aothms commented Sep 19, 2025

That's a matter of interpretation, especially for the templates. One person considers them just documentation, the next person considers them something formal. I've never seen the compatibility document that was drafted together with ISO, but I guess the answer is there.

At this point it's probably easier to just park it for the official update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants