Small patches / typos #992
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aothms
requested changes
Oct 8, 2025
docs/schemas/core/IfcProductExtension/Entities/IfcDistributionElementType.md
Outdated
Show resolved
Hide resolved
| # IfcDoorLiningProperties | ||
|
|
||
| The door lining is the frame which enables the door leaf to be fixed in position. The door lining is used to hang the door leaf. The parameters of the door lining define the geometrically relevant parameter of the lining. | ||
| The door lining is the frame which enables the door leaf to be fixed in position. The door lining is used to hang the door leaf. The parameters of the door lining define the geometrically relevant parameters of the lining. |
Collaborator
There was a problem hiding this comment.
Can we fix this:
The parameters of the door lining define the geometrically relevant parameters of the lining.
This sounds awfully circular
Contributor
Author
There was a problem hiding this comment.
To
The parameters of the door lining define its geometric characteristics.
?
| * LiningOffset, given if the lining edge has an offset to the x axis of the local placement. | ||
|
|
||
| > NOTE In addition to the <em>LiningOffset</em>, the local placement of the <em>IfcDoor</em> can already have an offset to the wall edge and thereby shift the lining along the y axis. The actual position of the lining is calculated from the origin of the local placement along the positive y axis with the distance given by <em>LiningOffset</em>. | ||
| > NOTE In addition to the <em>LiningOffset</em>, the local placement of the <em>IfcDoor</em> can already have an offset to the wall edge and thereby shift the lining along the y axis. The actual position of the lining is calculated from the origin of the local placement along the positive Y-axis with the distance given by <em>LiningOffset</em>. |
Contributor
Author
There was a problem hiding this comment.
Changed it every, also for x axis (to X-axis)
0a741fe
docs/schemas/domain/IfcArchitectureDomain/Entities/IfcDoorPanelProperties.md
Outdated
Show resolved
Hide resolved
| Input audio. | ||
|
|
||
| #### SOURCE_Speakers_AMPLIFIER_ELECTROACCOUSTIC | ||
| #### SOURCE_Speakers_AMPLIFIER_ELECTROACOUSTIC |
Collaborator
There was a problem hiding this comment.
Again, hidden structure everywhere, but these are references to identifiers in UML. And apparently the typo is not present there, so even better that his is fixed.
$ grep ELECTROACOUSTIC IFC.xml
<ownedLiteral xmi:type="uml:EnumerationLiteral" xmi:id="EAID_CC98D225_778C_1B19_E053_5801400A16D7" name="ELECTROACOUSTIC" visibility="public"/>
<packagedElement xmi:type="uml:Class" xmi:id="EAID_295C000F_FEA3_4274_8FCB_F6753649963E" name="IfcDistributionSystemEnum.ELECTROACOUSTIC" visibility="public"/>
<attribute xmi:idref="EAID_CC98D225_778C_1B19_E053_5801400A16D7" name="ELECTROACOUSTIC" scope="Public">
<element xmi:idref="EAID_295C000F_FEA3_4274_8FCB_F6753649963E" xmi:type="uml:Class" name="IfcDistributionSystemEnum.ELECTROACOUSTIC" scope="public">
<model ea_localid="3890" type="Class" name="IfcDistributionSystemEnum.ELECTROACOUSTIC"/>
| <!-- end of short definition --> | ||
|
|
||
| It is used to define a electric appliance type specification indicating the specific product information that is common to all occurrences of that product type. The **IfcElectricApplianceType** may be declared within _IfcProject_ or _IfcProjectLibrary_ using _IfcRelDeclares_ and may be exchanged with or without occurrences of the type. Occurrences of **IfcElectricApplianceType** are represented by instances of _IfcElectricAppliance_. Refer to the documentation at _IfcElectricAppliance_ for supported property sets, materials, composition, and ports. | ||
| lectric appliance type specification indicating the specific product information that is common to all occurrences of that product type. The **IfcElectricApplianceType** may be declared within _IfcProject_ or _IfcProjectLibrary_ using _IfcRelDeclares_ and may be exchanged with or without occurrences of the type. Occurrences of **IfcElectricApplianceType** are represented by instances of _IfcElectricAppliance_. Refer to the documentation at _IfcElectricAppliance_ for supported property sets, materials, composition, and ports. |
Contributor
Author
There was a problem hiding this comment.
Think this went wrong with VSCode search & replace. Went over all the changed files and fixed it
docs/schemas/domain/IfcElectricalDomain/Entities/IfcElectricFlowTreatmentDeviceType.md
Outdated
Show resolved
Hide resolved
docs/schemas/shared/IfcSharedBldgServiceElements/Entities/IfcEnergyConversionDeviceType.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.