Todolist: Implement Core Functionality of the command_queue Module#337
Open
yaohaowei0914 wants to merge 6 commits intobytedance:mainfrom
Open
Todolist: Implement Core Functionality of the command_queue Module#337yaohaowei0914 wants to merge 6 commits intobytedance:mainfrom
yaohaowei0914 wants to merge 6 commits intobytedance:mainfrom
Conversation
…tokens - Add max_completion_tokens support to ModelConfig - Update API call logic to use correct token parameter - Maintain backward compatibility with max_tokens
Fix TypeError in ModelConfig dataclass where non-default arguments followed default arguments. The issue occurred because 'max_tokens' (with default value None) was positioned before required parameters like 'temperature', 'top_p', 'top_k', 'parallel_tool_calls', and 'max_retries' which have no default values. Python dataclasses require all parameters without default values to be declared before parameters with default values. Changes: - Moved required parameters (temperature, top_p, top_k, parallel_tool_calls, max_retries) to the beginning of the dataclass - Moved optional parameters (max_tokens, supports_tool_calling, etc.) after required ones Fixes the CLI startup error: "TypeError: non-default argument 'temperature' follows default argument"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Core Module Files
Key Features Implemented
CLI Command Extensions
Architecture Design
CommandQueue (Core Class)
├── Queue Management (add_command, get_commands, cancel_command)
├── Status Monitoring (get_queue_status, _is_processor_running)
├── Persistence (_save_queue, _load_queue)
└── Processor (process_queue)
Key Technical Features
Data Structure
@DataClass
class QueuedCommand:
id: str # Unique identifier
task: str # Task description
working_dir: str # Working directory
options: Dict[str, Any] # CLI option parameters
status: CommandStatus # Command status
created_at: float # Timestamp of creation
error_message: str = "" # Error message (optional)
Business Value
Technical Advantages
Development Efficiency
Compatibility