fix: use bare raise instead of raise e to preserve traceback#403
Open
hobostay wants to merge 1 commit intobytedance:mainfrom
Open
fix: use bare raise instead of raise e to preserve traceback#403hobostay wants to merge 1 commit intobytedance:mainfrom
hobostay wants to merge 1 commit intobytedance:mainfrom
Conversation
In mcp_client.py, `except Exception as e: raise e` loses the original traceback, making debugging harder. Use bare `raise` to preserve the full exception chain. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Test User seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp_client.py:71that loses the original tracebackProblem
In
MCPClient.connect_and_discover(), the exception handler:This discards the original traceback, making it harder to debug issues. In Python,
raise ecreates a new exception from the current location, while bareraisepreserves the original traceback and exception chain.Fix
Changed to bare
raiseto preserve the full exception context for debugging.Test plan
🤖 Generated with Claude Code