fix: replace bare except clauses with except Exception - #42
Open
KeloYuan wants to merge 1 commit into
Open
Conversation
- modules/technos/cloudflare.py: bare except -> except Exception - modules/cp_cve/CVE202557822.py: bare except -> except Exception Bare except clauses catch SystemExit and KeyboardInterrupt, which can mask critical signals and make debugging harder.
There was a problem hiding this comment.
Pull request overview
This PR improves exception handling hygiene by replacing two bare except: clauses with except Exception: so that KeyboardInterrupt/SystemExit can still propagate during scans and debugging.
Changes:
- Update
modules/technos/cloudflare.pyto useexcept Exception:instead of a bareexcept:. - Update
modules/cp_cve/CVE202557822.pyto useexcept Exception:instead of a bareexcept:in the nested request block.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/technos/cloudflare.py | Narrows a previously bare exception handler to Exception to avoid catching system-exiting exceptions. |
| modules/cp_cve/CVE202557822.py | Narrows an inner bare exception handler to Exception while preserving existing control flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces 2 bare
except:clauses withexcept Exception:in:modules/technos/cloudflare.py(line 51)modules/cp_cve/CVE202557822.py(line 83)Why
Bare
except:catchesSystemExitandKeyboardInterrupt, which can:Using
except Exception:preserves the same error handling behavior while respecting system-level exceptions.