Skip to content

fix: Smart/Origin: fixed navitia api not accepting nb transfers to be -1#4566

Merged
eddy-geek merged 1 commit into
masterfrom
smart-origin/garantie1
Jun 16, 2026
Merged

fix: Smart/Origin: fixed navitia api not accepting nb transfers to be -1#4566
eddy-geek merged 1 commit into
masterfrom
smart-origin/garantie1

Conversation

@lgourdin

@lgourdin lgourdin commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

(cherry picked from commit 867c3c5d2a375f2b0ad56a74f4c21627abeedf29)

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Fixed the handling of transfer limits in trip planning when transfer limiting is disabled.

(cherry picked from commit 867c3c5d2a375f2b0ad56a74f4c21627abeedf29)
@github-actions github-actions Bot added the bug Something isn't working label Jun 5, 2026
@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b29bcde7-ca32-4436-89cd-621b3d27824f

📥 Commits

Reviewing files that changed from the base of the PR and between a77216a and 2d65856.

📒 Files selected for processing (1)
  • src/views/document/utils/boxes/PlanATripSection.vue

Walkthrough

The PR updates the maxNbTransfers computed property in PlanATripSection.vue to return undefined instead of -1 when transfer limiting is disabled. This affects the optional max_nb_transfers route query parameter passed during trip planning.

Changes

Transfer limit parameter handling

Layer / File(s) Summary
maxNbTransfers fallback value
src/views/document/utils/boxes/PlanATripSection.vue
maxNbTransfers computed property returns undefined when limitTransfers is false, changing the optional transfer-limit query parameter from -1 to undefined.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • c2corg/c2c_ui#4435: Both PRs modify PlanATripSection.vue's maxNbTransfers computed property—one sets it to -1 when limitTransfers is false, while the other changes that fallback to undefined.

Suggested labels

bug

Poem

🐰 A transfer that jumps from minus one so gray,
Now settles to undefined, the cleaner way,
When transfers take flight and limits are done,
The trip planning routes with nowhere to run! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing the Navitia API issue where nb_transfers cannot be -1 by returning undefined instead.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch smart-origin/garantie1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@eddy-geek eddy-geek merged commit f9a4a98 into master Jun 16, 2026
9 checks passed
@eddy-geek eddy-geek deleted the smart-origin/garantie1 branch June 16, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants