Feature: Dark Theme on Web#7
Draft
evowizz wants to merge 2 commits intoc5inco:mainfrom
Draft
Conversation
c5inco
reviewed
Sep 6, 2023
| darkModeSupported = true, | ||
| darkMode = useDarkTheme, | ||
| onDarkModeChange = { | ||
| // TODO: Find out why toggling dark mode on or off doesn't work |
Owner
There was a problem hiding this comment.
I think I was able isolate what the issue is. It's with TextField. You can repro with this snippet:
So likely a thing to go investigate with JetBrains.
Author
There was a problem hiding this comment.
This is quite surprising. I recreated something similar to your example. From what I was able to test, the issue with TextField only happened after I added a Surface. But then I replaced the Surface with the .background modifier on Column, and this specific issue didn't seem to happen anymore. There are other issues, but toggling still works nonetheless when using .background for some reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a "Dark Theme" toggle above the "Show Code" one as seen below.
This is a work in progress. Currently, toggling the theme causes an exception causing the UI to freeze.