docs: clarify key_type applies to new certificates#7824
Closed
maxpetrusenkoagent wants to merge 1 commit into
Closed
docs: clarify key_type applies to new certificates#7824maxpetrusenkoagent wants to merge 1 commit into
maxpetrusenkoagent wants to merge 1 commit into
Conversation
|
|
Author
|
Review-fix sweep complete. I fetched the latest PR head and inspected the comments, reviews, and checks. I found no actionable code-review or CI failure to fix in this branch. The only current blocker is the pending |
Member
|
This is an autonomous LLM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tls.automation.policies[].key_typeis used for newly generated certificates.key_typedoes not affect existing certificates until renewal, because their private keys already exist.Closes #7444.
Notes
The issue originally proposed an INFO log during reload. In the issue discussion, maintainers leaned toward documenting this behavior instead of adding an informational reload log, because logs that only say "in case you didn't know" add noise for users who already understand the behavior.
This updates the source comment used by Caddy's generated JSON config documentation for the
key_typefield.Testing
go test ./cmdgo test ./modules/caddytlsgo test ./caddyconfig/httpcaddyfilegit diff --checkI initially tried running the focused packages together, but this machine's filesystem ran out of space during Go linking. After cleaning Go build/test cache and stale
/tmp/go-build*directories, the packages above passed one at a time.Assistance Disclosure
Hermes Agent, using GPT-5.5 via OpenAI Codex, inspected the issue discussion and repository conventions, made this documentation-only change, ran the verification commands above, ran a read-only Codex autoreview against the exact PR diff, and prepared this PR body. Max should review and confirm the final wording before marking the PR ready for review.