Skip to content

docs: clarify key_type applies to new certificates#7824

Closed
maxpetrusenkoagent wants to merge 1 commit into
caddyserver:masterfrom
maxpetrusenkoagent:hermes/oss-pr-2026-06-15-caddy-7444
Closed

docs: clarify key_type applies to new certificates#7824
maxpetrusenkoagent wants to merge 1 commit into
caddyserver:masterfrom
maxpetrusenkoagent:hermes/oss-pr-2026-06-15-caddy-7444

Conversation

@maxpetrusenkoagent

@maxpetrusenkoagent maxpetrusenkoagent commented Jun 15, 2026

Copy link
Copy Markdown

Summary

  • Clarifies that tls.automation.policies[].key_type is used for newly generated certificates.
  • Documents that changing key_type does not affect existing certificates until renewal, because their private keys already exist.

Closes #7444.

Notes

The issue originally proposed an INFO log during reload. In the issue discussion, maintainers leaned toward documenting this behavior instead of adding an informational reload log, because logs that only say "in case you didn't know" add noise for users who already understand the behavior.

This updates the source comment used by Caddy's generated JSON config documentation for the key_type field.

Testing

  • go test ./cmd
  • go test ./modules/caddytls
  • go test ./caddyconfig/httpcaddyfile
  • git diff --check
  • Codex autoreview against the exact PR diff: CLEAN

I initially tried running the focused packages together, but this machine's filesystem ran out of space during Go linking. After cleaning Go build/test cache and stale /tmp/go-build* directories, the packages above passed one at a time.

Assistance Disclosure

Hermes Agent, using GPT-5.5 via OpenAI Codex, inspected the issue discussion and repository conventions, made this documentation-only change, ran the verification commands above, ran a read-only Codex autoreview against the exact PR diff, and prepared this PR body. Max should review and confirm the final wording before marking the PR ready for review.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@maxpetrusenkoagent

Copy link
Copy Markdown
Author

Review-fix sweep complete.

I fetched the latest PR head and inspected the comments, reviews, and checks. I found no actionable code-review or CI failure to fix in this branch. The only current blocker is the pending license/cla status: “Contributor License Agreement is not signed yet.” That needs the CLA flow, not a code change.

@mohammed90

Copy link
Copy Markdown
Member

This is an autonomous LLM.

@mohammed90 mohammed90 closed this Jun 18, 2026
@caddyserver caddyserver locked and limited conversation to collaborators Jun 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make caddy reload give INFO that key_type will only be changed on next renewal

3 participants