Refactor pycgmKinetics.py to kinetics.py #92
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khgaw
changed the title
khgaw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of PR:
This PR refactors pycgmKinetics.py. This PR removes and fixes any functions that can be replaced with the numpy version.
What issues does this PR close:
PEP8 formatting
Refactoring functions
What files were changed and what changes were made?
init.py - created to run pytest
kinetics.py - fixed PEP8 formatting, removed vector() which is similar to np.subtract() (and fixed the differences in the rest of the code) and removed add() which is the same as np.add(). Combined smaller functions into get_kinetics(). Changed find_L5 function to take in a 4x4 matrix for the axis
test_kinetics.py - Removed tests for functions that do not exist anymore, changed unit tests to round to 5 decimal places.
Does your PR (check all that applies):
Are there any errors/relevant logs in your code?
No
How has this been tested?
Run doctests/pytest