Open
Conversation
- repeated wallets post migration - newly created wallets not showing up - extra large components on desktop, needed maxwidth
MrCyjaneK
reviewed
Feb 25, 2026
6 tasks
OmarHatem28
requested changes
Mar 3, 2026
Contributor
OmarHatem28
left a comment
OmarHatem28
left a comment
There was a problem hiding this comment.
I merged Czarek's PR, it handles the duplicate wallets with a better approach, so please remove the workaround for it.
everything else looks good
MrCyjaneK
reviewed
Mar 4, 2026
| bool _needsUpdate = false; | ||
|
|
||
| @action | ||
| Future<void> updateList() async { |
Collaborator
There was a problem hiding this comment.
Maybe use mutex here instead of recursively calling itself? Something may await it in future/now, and this flow is confusing when we consider function signature.
Contributor
Author
There was a problem hiding this comment.
Yeah, that's a better approach
I've switched it to a Future based mutex, so each caller would wait for the previous update call to finish, and then runs, removing the recursion.
… a future based mutex
…into desktop-wallet-issues
…proved drag threshold logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number (if Applicable): Fixes #
Description
Please include a summary of the changes and which issue is fixed / feature is added.
Pull Request - Checklist