feat: Add runtime registry configuration support #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add registryUrl prop to CalimeroProvider - Use package-name instead of manifest-url for auth flow - Support both production and local registries - Fix routing to use nip.io domain for merobox nodes
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Updated scripts: - upload-and-submit.sh - submit-new-version.sh Old: https://mero-registry.vercel.app New: https://apps.calimero.network These scripts now default to the official production registry.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| versions.push({ | ||
| semver, | ||
| cid: manifest.artifacts[0]?.cid || '', | ||
| cid: manifest.artifact?.digest || '', // v1 format uses 'artifact' (singular) |
There was a problem hiding this comment.
Bug: Artifact field mismatch breaks old-format manifests
Type mismatch: The code accesses manifest.artifact?.digest but the AppManifest interface only defines artifacts (plural array), not artifact (singular object). While the code handles both V1 format (with singular artifact) and old format (with plural artifacts array) at runtime, manifests stored via the old /apps POST endpoint only have the artifacts array property. This will cause manifest.artifact to be undefined for those manifests, making the CID always empty string for non-V1 manifests, breaking version tracking for old-format apps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Standardizes registry API format and fixes local CLI compatibility.
Changes
/apps/:id/:version) as primary formatlocal-storage.tsto useartifact(singular) for v1 manifestsRelated PRs
Status
✅ All tests passing
✅ Local and remote registries working
🔒 DO NOT MERGE - Working baseline
Note
Aligns local CLI with V1/Vercel formats and updates scripts to the new registry domain.
packages/cli/src/lib/local-server.ts:/apps/:appIdnow returnsversionsasstring[](mapsVersionInfo.semver).packages/cli/src/lib/local-storage.ts:getAppVersionsreads CID fromartifact.digest(V1 format) instead ofartifacts[0].cid.scripts/submit-new-version.sh,scripts/upload-and-submit.sh: defaultREGISTRY_URLswitched tohttps://apps.calimero.network.Written by Cursor Bugbot for commit 26d874f. This will update automatically on new commits. Configure here.